Andrew Hopp

Results 54 comments of Andrew Hopp

I'm just going to update based on those assumptions. This is what it will look like with the updated CX for Lucene and DQL; Not expanded for "Recent queries" Expanded...

I've made the updates. Somewhat related, when I look at the code, I see drift between the PPL/SQL work and the established CX. I think there needs to be some...

I looked at the 'RecentQueriesTable' component and is seems to correctly filters by language and query history storage does uses 'QueryHistory' class. If you look at `setQueryStringWithHistory` action has `meta:...

Okay, I was able to fix the issue locally. I'll open a PR. Working with Lucene: Working with DQL:

@tronboto You can take a look at [#10837](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/10837) if you want to see the PR for the changes. It's working locally for both Lucene and DQL but we'll see what...

Note for the PR, looks like the PPL/SQL team has implemented a different CX that we will need to align to before merging. Will delay the bug fix for a...

Okay, I think the bug occurs because PPL and SQL search interceptors bypass the base SearchInterceptor's error handling and cleanup logic. The Problem Flow: Base SearchInterceptor (search_interceptor.ts:224-256): - Has a...

Is this solely governed by vis_type_vega.max_url_results? Isn't the index.max_result_window also set to 10,000 default? Regardless, I agree that the visualization shouldn't silently truncate. To fix this, I think we would...

Sorry, @JoungDongHee, I was treating that as all one option. Step #1 is add detection, step #2 is display the detected warning, and step #3 is log for debugging if...