Alex Nitz
Alex Nitz
@GarethCabournDavies I think this is a long overdue good thing to do. Thank you for looking into this!
@GarethCabournDavies Yes, remove pycbc_submit_dax has my vote.
@spxiwh We'll have @alishahassan update the PR with those changes.
This has more to do with how we want to handle the heirarchical analysis. @cdcapano Should weigh in
@titodalcanton As a first step should we force numpy 2.0 to be used for tests? Although as you suggest, this probably is incompatible with some other libraries.
@GarethCabournDavies Note that where they exist all constants should come from the standard python stack and not other sources. The order of operations should be astropy -> scipy -> numpy...
@JulienGreuter @titodalcanton Out of curiosity, is there a reason that rejection sampling is used here? Given that healpix format is a discretization of the sky space, one should be able...
@xkzl Does this PR https://github.com/gwastro/pycbc/pull/4620 address the issue in your use case? If not, we are happy to accept PRs here to help improve this behavior for everyone. Or suggestions...
@xkzl Thank you for that suggestion. That's seems like a very straightforward change so I've created a PR #4890 to correct this.
@xkzl When you get the chance, let us know if this issue is now resolved. If you are satisfied, please close this issue, otherwise, and update on what further problems...