Ahmet Alp Balkan
Ahmet Alp Balkan
Yeah it's by design and not related to this tool. It's also a won't fix on Krew.
:robot: _Beep beep! I’m a robot speaking on behalf of @ahmetb._ :robot: ----- Thanks for submitting your kubectl plugin to Krew! One of the krew-index maintainers will review it soon....
:robot: _Beep beep! I’m a robot speaking on behalf of @ahmetb._ :robot: ----- Thanks for submitting your kubectl plugin to Krew! One of the krew-index maintainers will review it soon....
I can accept this plugin, but fundamentally I think the tool is doing a "name grab" and is a bit limited-purpose, since it can only update `Node` conditions and nothing...
I think I initially overreacted, sorry. If the name were "conditions" but it was doing only working on some resource conditions, it would've been a generic name grab situation limiting...
:robot: _Beep beep! I’m a robot speaking on behalf of @ahmetb._ :robot: ----- Thanks for submitting your kubectl plugin to Krew! One of the krew-index maintainers will review it soon....
Sorry for the very delayed review. /lgtm /approve Thanks! Also, please consider setting up [Krew release automation](https://krew.sigs.k8s.io/docs/developer-guide/release/automating-updates/) which helps you skip manually making updates to your Krew manifests on each...
That's weird. I assumed client auth plugins (exec and oidc) no longer need to be imported in plugins. I suspect you'll hit this in many other kubectl plugins (beware). I...
Ah those usually shell out to kubectl; not use the client-go client.
@manuelbuil please take a look