flannel icon indicating copy to clipboard operation
flannel copied to clipboard

capture close() err on subnet file save

Open ahmetb opened this issue 6 months ago • 2 comments

Description

The OS may accept write()s but may fail on close(), which is currently ignored. Because it's ignored, it won't be logged anywhere either. (I'm sending this PR because I'm seeing missing subnet.env file on disk, but there's no Failed to write subnet file).

Todos

  • [ ] Tests: N/A
  • [ ] Documentation: N/A
  • [ ] Release note: N/A

Release Note

None required

ahmetb avatar Jun 12 '25 17:06 ahmetb

@manuelbuil please take a look

ahmetb avatar Jun 16 '25 21:06 ahmetb

That change looks good. Given that the buffer will not get superbig, I think this approach makes more sense. Thanks @ahmetb

manuelbuil avatar Jun 17 '25 14:06 manuelbuil