Ahmed Fwela

Results 119 comments of Ahmed Fwela

ok all checks are passing, gonna need more test schemas for polymorphism, are there any good ones ? @wing328

why make separate PRs tho? it will take more time to merge and sync both than just one PR

but the plain `BuiltValue()` is part of this PR so that built_value can detect classes when they don't implement `Built` interface also `StructuredSerializer` casting can be put in the serializer...

I have also stumbled on something interesting, in `csharp-netcore` the generator doesn't support having properties in addition to `oneOf`/`anyOf` relevant links: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/csharp-netcore/model.mustache#L44 https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/csharp-netcore/modelOneOf.mustache https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/csharp-netcore/modelAnyOf.mustache but I have found schemas where...

I rewrote the serializers and the class definition I also moved the oneOf serialization handling to a separate package complete with its own tests here: https://github.com/Bdaya-Dev/dart-oneof/blob/main/one_of_serializer_tests/test/one_of_serializer_tests.dart https://pub.dev/packages/one_of_serializer right now, it...

the change to `PrimitiveSerializer` is to handle oneOf primitives (e.g. oneOf `num`, `SomeComplexObject`) and I tested that returning a `List` from a `PrimitiveSerializer` gives it the same behavior as a...

@banool they are nothing alike to be honest, my PR adds support for oneOf, anyOf, inheritance and discriminator lookup the other PR just fixes the name generation and uses dynamic...

it's because these schemas are parents to other schemas the basic idea is this: abstract class A implements B, C, Built abstract class B abstract class C means B, C...

you are right, I definitely need to document this better. and thinking about it now, this actually is a breaking change it might be better to add a flag for...

tbh, it would be great to leave this as the default behavior even if it is a breaking change, since the old behavior was very annoying for me