Ahmed Moheb

Results 11 comments of Ahmed Moheb

Hi @yperess and @thoh-ot , could you review again or mark your change request as resolved? @yperess regarding moving from ZTest mocks to FFF, a following PR will do the...

> > I'll take a look at the unittest / Kconfig support. > > Kconfig support is now ready here: #48732 > > @ahmedmoheb-nordic please try it out for Kconfig...

> > Only thing is that I really would like @cvinayak or @Thalley to take a look at this comment: [#47794 (comment)](https://github.com/zephyrproject-rtos/zephyr/pull/47794#discussion_r958468842) > > so will give a little time...

> lgtm, thanks for the effort +1 Thanks to vote again for the changes

> @ahmedmoheb-nordic cannot add you as reviewer, but please test this PR and give comments. @tejlmand I think there is a problem that not all defined configuration parameters were added...

> > Seems `autoconf.h` is not applied on sources being compiled. Looking into this. > > `DNM` for now. > > fixed I tested it and it's working now

@tejlmand I found another issue related to not including the `autoconf.h` while building sources. For one of the unit test projects, I tried to build a simple library by adding...

@jori-nordic @kruithofa please review

> I see some of my comments could make it a pain to update all the other commits, and it will be hard to see if they're resolved across all...

> I see some of my comments could make it a pain to update all the other commits, and it will be hard to see if they're resolved across all...