ahmedbilal9
ahmedbilal9
The CI failures appear to be unrelated to my changes. The build is failing with: Error: roofit/hs3/src/RooJSONFactoryWSTool.cxx:260:1: error: '{anonymous}::Var::Var' defined but not used [-Werror=unused-function] This error is in C++ RooFit...
Hi @bellenot, I've fixed the Python linting errors as requested. The `ruff` check now passes successfully . However, the CI is failing with an error in RooFit code that appears...
> Hi @ahmedbilal9 I see failures like: > > ``` > 1795:roottest-main-SimpleRootmv1 > 1796:roottest-main-SimpleRootmv1CheckOutput > 1797:roottest-main-SimpleRootmv1Clean > ``` > > And not the one with RooFit Hi @bellenot, Thank you...
> @ahmedbilal9 see https://github.com/root-project/root/runs/54877340609 I see that the workflows haven't run yet and there are no CI logs available for the rootcp tests. Could a maintainer please approve or trigger...
Summary - Fixes #7052: --replace was ignored in recursive copy for non-tree, non-collection objects, causing new cycles instead of replacing. - Also makes collection handling robust by using ROOT RTTI...
Hi @guitargeek, I hope you’re doing well. I wanted to follow up on my pull request #20344 ([IO] Fix rootcp --replace flag not working with recursive copy) which I opened...
> I'd like to mention that this PR may become not mergeable as-is if [this](https://github.com/root-project/root/pull/20536) gets merged (or anyway will be de facto undone if it's merged before it), since...
> > fixes #17095 > > You mean #20470 ? pardon me, yes!
Hi @dpiparo, @hahnjo, @silverweed - just wanted to gently ping on this PR. All tests are passing and I'm happy to address any feedback. Thanks for your time reviewing!
> Judging from [the forum posts](https://root-forum.cern.ch/t/root-does-not-respect-default-acl/35824/8) referenced by the linked issue, this is more of a policy decision than a technical one as far as I understand, and I think...