Ahmed Abualsaud

Results 43 comments of Ahmed Abualsaud

friendly ping @chamikaramj @robertwb

Thanks for looking @chamikaramj. I addressed these comments, PTAL

Thank you @lostluck, yes best to let it bake and get it in the next release

> What if instead they were in a single subdirectory (like with protos) I like this alternative more actually. I've made some changes to instead generate wrappers inside the `apache_beam.transforms._external_transforms`...

Successful PreCommit run: https://github.com/ahmedabu98/beam/actions/runs/7714357594/job/21026416076

R: @tvalentyn R: @robertwb Ready for another review!

Running `./gradlew generateExternalTransformWrappers` fails on my side because of this line in apache_beam.io: `from apache_beam.transforms.xlang.io import *`. It fails because the script initially cleans up the generated modules, then imports...