ahmedGaber93
ahmedGaber93
Testing on staging `childReportID` is not present with `pusher` data and present only on `API` data. https://github.com/user-attachments/assets/059233e1-d97b-4295-b38a-1c54bfc9fd94
> The issue that you mentioned with canHoldUnholdReportAction happens [here](https://github.com/Expensify/App/blob/7bfb34527508b47732cab6d4280a943ffab48066/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx#L155) since we are unable to fetch childReport for the IOU report action. I agree with this part, the `parentReportActionID` also...
@CortneyOfstad bump https://github.com/Expensify/App/issues/52401#issuecomment-2487676060
Not overdue, waiting for an internal developer.
Not overdue, waiting for an internal developer.
Reviewing today
@bernhardoj I love your idea using `beforeRemove`, And I see you used it before [here](https://github.com/Expensify/App/pull/52741/files#diff-32285433d71b2da430cce772f2c74b646229930b36cfd54a93803c7f266afd69). But I have some question: 1. How we will prevent the `beforeRemove` that will trigger...
@bernhardoj, can we know how many places/forms are use @react-navigation/native-stack and will be affected with this limitation, I believe RHP will not be affected
> What do you think about my proposal? @mkzie2 I think it has the same idea from bernhardoj proposal https://github.com/Expensify/App/issues/53679#issuecomment-2523352545
@bernhardoj's [proposal](https://github.com/Expensify/App/issues/53679#issuecomment-2523352545) using [beforeRemove](https://reactnavigation.org/docs/6.x/preventing-going-back/) listener can do the job with some [limitations](https://reactnavigation.org/docs/6.x/preventing-going-back/#limitations), I think the important limitation is it will not support back gesture in iOS util we upgrade `@react-navigation/native-stack`...