ahmed-novalabs

Results 7 comments of ahmed-novalabs

> Thanks @ahmed-novalabs ! What's left to do yet? The font fallback isn't well-implemented and has some bugs, I didn't add any tests for bidi or the font fallback. There...

I removed the font fallback code since it was done in a primitive way, If I get the time, I will work on another PR. Only testing is missing now.

@diegomura I don't have a lot of experience with testing, so I am not sure how to make or approach making a test plan. If you can provide an example...

@benshabatnoam yes you can. You can follow the [contributing guide](https://github.com/diegomura/react-pdf/blob/master/.github/CONTRIBUTING.md#set-up-your-development-environment) on how to set it up. No extra steps were necessary for me.

> @ahmed-novalabs but how did you do to code this? By test plan all I mean is a way to see it working and understand how it works Sorry, I...

@diegomura I think the main benefit is optimization by only loading the used fonts based on the text and `unicodeRange`. The behavior should be to load all the used fonts...

What's in this PR - Added `unicodeRange` to the font object to support loading only needed fonts - Added support for multiple fonts per `` by modifying the font substitution...