Saim Ahmad
Saim Ahmad
Hi @rothsandro , I’d like to work on fixing the IconDefinition type so that the ligatures property can accept both numbers and strings. I plan to submit a PR shortly....
Hi @rothsandro and team, this PR updates the IconDefinition type to allow ligatures as both numbers and strings. Please review when you get a chance. Thanks!
What a notice bro!!
Hi @alya This pr is the extended, cleaned and neat version of the previous PR (https://github.com/zulip/zulip/pull/36652) was closed due to a force-push; all requested changes have been reapplied to this...
@alexmv Sr Please Review it and tell me if any changes need otherwise please merge it so that i could work on further issues
Thanks for taking the time to review everything so thoroughly — I genuinely appreciate it. I understand the feedback, and I’ll make sure every point is addressed carefully without rushing...
@alexmv Thank you for the detailed feedback. I've removed all four useless comments and corrected the commit message to proper Zulip prose format with the 8-core benchmark detail included. All...
Thanks for clarifying. > Additionally, please add a separate commit which addresses the confusing log outputs (which AFAICT are not caused by this commit, but we should clean up while...
If I'm missing something still, please guide me
@alexmv sr please review it and also tell me more about the logs, so that i'll work at there and work on more issues