Andreas Herrmann

Results 248 comments of Andreas Herrmann

Another alternative for bazel-in-bazel integration testing next to [rules_go](https://github.com/bazelbuild/rules_go/blob/master/go/tools/bazel_testing/def.bzl) and [bazel-integration-testing](https://github.com/bazelbuild/bazel-integration-testing) is [rules_bazel_integration_test](https://github.com/cgrindel/rules_bazel_integration_test). Relatedly, there is [rules_bzlformat](https://github.com/cgrindel/rules_bzlformat) which offers an alternative for `buildifier` based linting with convenient macros to generate...

Agreed, that sounds like a useful feature. Worth noting, the current setup doesn't generate an executable file within Bazel's execroot, instead it points directly into the Nix store, see [here](https://github.com/tweag/rules_nixpkgs/pull/103)...

Addressed by https://github.com/tweag/rules_nixpkgs/pull/261

Nice! Thank you for looking into this! > But providing such an expression is difficult because the wrapper (the buildEnv call) needs to be duplicated. Any reason why we do...

@jystic I stumbled upon this thread while looking to understand the semantics of `Gen.choice` vs. ``. It seems to me that those two have very different meaning. I'm using `Gen.sample`...

> If you want to play around, you can get the desired behaviour in the current system by doing something awful :laughing: > > `Gen.sample (let g = Gen.choice [empty,...

@coeuvre We spoke at BazelCon, I mentioned this PR to you, and you asked me to ping you on it. What would you say is missing and what's the best...

> It seems that this PR tries to do two things: > > 1. Retry the download/upload if certain errors happened. > > 2. Upon retry of download, continue the...

> I think it is safe to do for CAS where the key represent a specific content, but a retried download of AC key could result in different ActionResult. And...

@coeuvre @ulrfa @avdv Thank you for the review! I’ve changed the retry logic such that retries of `ActionResult` fetches start a new download from scratch and write into a fresh...