Andreas Herrmann

Results 248 comments of Andreas Herrmann

> It looks like it's not possible to build meaningful abstractions in repository rules, because we can't have a repository rule depend on another repository rule (only files). Given that,...

@jamesthompson Thank you for the detailed report and the reproduction test-case. I'm able to reproduce the issue on Linux with nixpkgs. There are two issues at play here: 1) Paths...

@jamesthompson Thanks for the follow-up, that's good to know. If `libpgcommon.a` is not required then you can avoid the issue without using a `genrule` to copy files. Instead, you can...

> 1. Paths of external source files are different in the execroot than in the repository root. This aspect has been fixed in the meantime. The genrule trick is no...

It doesn't address the general case, but just to mention it, you can define global haddock flags [on the toolchain](https://api.haskell.build/haskell/defs.html#haskell_toolchain-haddock_flags), e.g. on [`haskell_register_ghc_nixpkgs`](https://api.haskell.build/haskell/nixpkgs.html#haskell_register_ghc_nixpkgs-haddock_flags). I agree, being able to set custom...

> If I build this target FIRST, then build my doctest, it does not fail. Thanks for the update. This sounds scary, it sounds like an undeclared dependency that somehow...

> Locally, it seems to intermittently check if the stack stuff is up to date. We [call `stack update` as a `local` repository rule](https://github.com/tweag/rules_haskell/blob/2c4c3567e1bef3528bb378dbfa98dd74546160e5/tests/binary-with-tool/BUILD.bazel), i.e. this is run whenever Bazel...

A caching section in the [use-cases documentation](https://github.com/tweag/rules_haskell/blob/master/docs/haskell-use-cases.rst) would be a good place for this.

`bazel test //tests/...` covers most tests in rules_haskell. However, there are a few tests that still require `//tests:run-tests`, e.g. failure tests, REPL tests, pinning tests... rules_go has [`go_bazel_test`](https://github.com/bazelbuild/rules_go/tree/2e339e9d5867ccc4e3b316006e21a7cc8a348398/go/tools/bazel_testing) to run...

@k1nkreet thank you for the structured outline! > * I suggest to keep this things orthogonal: manually create this filegroup, use it in `buildifier_test` and `go_bazel_test`-like rules and create a...