ally heev

Results 12 comments of ally heev

> @aheev > > Thanks for the PR! Could you add a comment to understand why PR#14136 was abandoned and how this PR addresses it? updated

@kamalcph found a new issue. Since metadataCache is [first updated](https://github.com/apache/kafka/blob/f81853ca8858fe1dfbb038ce39c8595a2a42c484/core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala#L132-L150) before `ReplicaManager.applyDelta`, [stopPartitions](https://github.com/apache/kafka/blob/42644b3045eb0be3d8646496ca43dfaca75b6923/core/src/main/scala/kafka/server/ReplicaManager.scala#L2360), inturn `rlm.stopPartitions` is not able to [find topicId](https://github.com/aheev/kafka/blob/42644b3045eb0be3d8646496ca43dfaca75b6923/storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java#L506). Why can't we just use `TopicIdPartition` in [StopPartition](https://github.com/apache/kafka/blob/5d2074e8f26a0573fd7d66cc4dfa68a9dae58dc4/server-common/src/main/java/org/apache/kafka/server/common/StopPartition.java#L26) class...

> Thanks for the patch! > > > Since metadataCache is [first updated](https://github.com/apache/kafka/blob/f81853ca8858fe1dfbb038ce39c8595a2a42c484/core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala#L132-L150) before ReplicaManager.applyDelta, [stopPartitions](https://github.com/apache/kafka/blob/42644b3045eb0be3d8646496ca43dfaca75b6923/core/src/main/scala/kafka/server/ReplicaManager.scala#L2360), inturn rlm.stopPartitions is not able to [find topicId](https://github.com/aheev/kafka/blob/42644b3045eb0be3d8646496ca43dfaca75b6923/storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java#L506). Why can't we just use TopicIdPartition...

@c-thiel can you please take a look? I will add the tests by tmrw PS: This is my first iceberg PR, pardon any noob mistakes :upside_down_face:

@c-thiel I have a couple of queries regarding the implementation - I took inspiration from [Namespace](https://github.com/apache/iceberg/blob/c07f2aabc0a1d02f068ecf1514d2479c0fbdd3b0/api/src/main/java/org/apache/iceberg/catalog/Namespace.java#L28) class for implementing `CatalogObject`. So, should we support EMPTY_CATALOG_OBJECT too, just like EMPTY_NAMESPACE? -...

Still some questions linger - What should be the structure of [CatalogObject](https://github.com/aheev/iceberg/blob/589deee54520004dd20f15e6a3507c5c374dd4de/api/src/main/java/org/apache/iceberg/catalog/CatalogObject.java)? Should it be same as `Namespace` or just a `string` containing the fully specified name of the object?...