Guido Günther

Results 85 comments of Guido Günther

This would still be great to have in case you want to give it a respin @iainlane

Thanks, one issue though: The patch object might not refer to an existing file (yet) so guessing might fail. I'd rather see the code to guess the strip level called...

...oh and we need a testcase that checks this one we know which way we want it.

Thanks for the update but please check how gbp-pq uses the patch series. It parses the series file without _ever_ looking into any patch file on disk (since the strip...

On Fri, May 20, 2016 at 01:34:01AM -0700, Dmitry Teselkin wrote: > @agx I'll try to add separate method as you've suggested, and will update the patch. Unfortunately, I'm not...

Hi, thanks for splitting this out. commit_all has an author_info so it should get a committer_info as well.

I spotted one other change that might introduce problems since __build_env would change return type and that gets passed to Popen and Popen's default type for "do nothing" is None...

can you demonstrate this with a testcase `tests/component/deb` that fails initially and works after your fix?

I'm a bit puzzled since if you use overlay then isn't the whole point that we're not generating an archive but use tarball-dir?

@andrewshadura thanks! This looks like a useful addition. Thinks i'm unsure about: - prefer lfs over tar or the other way around (and why)? (popcon seems to prefer `pristine-tar`) https://qa.debian.org/popcon-graph.php?packages=pristine-tar+pristine-lfs&show_installed=on&want_legend=on&want_ticks=on&from_date=&to_date=&hlght_date=&date_fmt=%25Y-%25m&beenhere=1...