Agriya Khetarpal

icon indicating a website link agriyakhetarp.al

icon company @Quansight icon location New Delhi, India icon location sentient stochastic parrot. @pyodide, @pybamm-team maintainer • @jupyterlite, @scientific-python contributor • member of @pypa and @numfocus security committee.

Results 984 comments of Agriya Khetarpal

Use `@cache` and `@cache_property` from `functools` for memoization

Hi @tinosulzer, I'd be happy to work on this!

Use `@cache` and `@cache_property` from `functools` for memoization

Apologies for the delay(s), I'll be working on this in this week!

Updated xl_col_to_name() method to add recursion

Hi @jmcnamara, how may I resolve the unsuccessful checks? The test is failing due to a whitespace of some sort in my code

Updated xl_col_to_name() method to add recursion

**Update**: I fixed "W293 blank line contains whitespace" with autopep8 in another commit. The tests probably should not fail now

Updated xl_col_to_name() method to add recursion

I'm on a Windows machine so I cannot run `make`, is there any other way to go about this? I tried it on WSL (Ubuntu) as well but there it...

Updated xl_col_to_name() method to add recursion

**Update:** resolved the above by installing `make` using [Chocolatey](https://github.com/chocolatey/choco). I ran the flake8 tests, and resolved four issues – E501, a couple of W291s, and a E115. `pytest` also passes...

Updated xl_col_to_name() method to add recursion

Thanks a lot @jmcnamara, – I shall look into benchmarking them this week and get back!

Updated xl_col_to_name() method to add recursion

I get your points. The recursive method may be a tad confusing to write (and understand!) in code, and also may not even be needed for practical purposes. I have...

Updated xl_col_to_name() method to add recursion

Apologies for the slight delay in sending these performance benchmarks – [here](https://gist.github.com/agriyakhetarpal/b390d26bdb1038faf830ce58f49946e6) they are in a GitHub Gist, as requested. The new implementation with `chr(ord('A')` has not been pushed yet...

Updated xl_col_to_name() method to add recursion

> So to be clear, just add another function to your gist called xl_col_to_name3() or similar Oh, I've actually done that in the benchmark file, just not in the PR....