Artem Grinchenko

icon indicating an email [email protected]

icon company Datastealth icon location ON, Canada

Results 8 comments of Artem Grinchenko

First commit

Thanks all for taking time to review and providing your feedback! Keep it coming! I will work on improving the code in the coming days.

First commit

> This work is wonderful, thanks for putting it together. > > I have mostly nits and checkstyles. > > However I do believe we need to invest in significant...

First commit

> I hope I can convince you not to follow the existing DKIM api which is really not so great. please have a look at the proposed API in #27...

First commit

I checked it a new commit with updates. Outstanding on my list: - look into making a module out of `dmarc` - check proposed API in https://github.com/apache/james-jdkim/pull/27 and see how...

First commit

> What method can be used to know if the sealer can be trusted ? I didn't see any in the ARCVerifier. The logic to validate previous ARC sealers is...

First commit

> > Let me think on making a module out of dmarc. My first instinct says it will probably be a very small module. But if it makes sense to...

First commit

Hey guys! I committed changes with DMARC in a separate module and also implemented both strict and relaxed header checking against PSL list. The Jenkins build fails though because `MockPublicKeyRecordRetrieverDmarc`...

First commit

Thanks, Benoit! No rush..