agrieve

I'm trying this out in chromium codebase, and besides the known-issue of excessive lambda whitespace (issue #19), I'm finding the most jarring thing is odd whitespace for variable assignments. google-java-format...

### Description When using a junit RunListener, it is expected that the order of events for a test with two `@Test` methods be: 1. RunListener.testSuiteStarted 1. Test.beforeClass 1. RunListener.testStarted 1....

Add module caching

1

Would be great if gnode had a disk cache of regenerated modules (based on md5) so the subsequent runs wouldn't have to pay the performance penalty.

I'm trying to enable ASAN in a bundle using [these instructions](https://github.com/google/sanitizers/wiki/AddressSanitizerOnAndroid/01f8df1ac1a447a8475cdfcb03e8b13140042dbd#running-with-wrapsh-recommended). When I add in the `wrap.sh` file as `lib/x86/wrap.sh`, install fails with these adb logs: ``` 04-20 01:56:31.898 548...

@MonotonicNonNull should allow null-assignment within constructors

1

Example: ``` @NullMarked class Foo { @MonotonicNonNull Object mBar; @Nullable Object maybeNull() { return null; } Foo() { mBar = maybeNull(); } } ``` Yields: ``` Foo.java:13: warning: [NullAway] assigning...

Nullness of generics is lost for "new Foo<@Nullable Object>().bar()"

3

This code: ```java import org.jspecify.annotations.NullMarked; import org.jspecify.annotations.Nullable; @NullMarked public class Foo { private static class Inner { Inner identity() { return this; } } Inner mThing = new Inner().identity(); }...

```java @NullMarked class Foo { interface Callback { void onResult(T result); } static void addCallback(Callback cb) { } static void removeCallback(Callback cb) { } public void main() { addCallback(new Callback()...

@MonotonicNonNull Should Consider Field non-null When Lambda is Assigned to It

2

Example: ``` @NullMarked class Foo { @MonotonicNonNull Runnable mRunnable; void foo() { mRunnable = () -> { // This should not warn about mRunnable being null. mRunnable.run(); }; } }...

NullAway dataflow analysis does not prune out infeasible paths

2

In the context of this [code review](https://chromium-review.googlesource.com/c/chromium/src/+/6107453), I found: // Complains that the contract is not satisfied ``` @Contract("_, !null -> !null") public @Nullable Set readStringSet(String key, @Nullable Set defaultValue)...

False-positive when dereferencing an inline-initialized field from constructor body

4

``` @NullMarked class Foo { private @Nullable Object mArgs = new Object(); Foo() { mArgs.getClass(); } } ``` Gives: ``` Foo.java:9: warning: [NullAway] dereferenced expression mArgs is @Nullable mArgs.getClass(); ^...