Amr A. Gouhar

Results 7 comments of Amr A. Gouhar

@mithro: The following gist contains a patch for each of https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_sc_hd/ and https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_sc_hdll/ if you apply the patches this issue will be resolved. https://gist.github.com/agorararmard/d117c1967449b5a78570a4296119ccc5

> * All documentation should use inclusive language https://opensource.google/docs/releasing/preparing/#inclusive > > * Repository should have a README file > https://opensource.google/docs/releasing/preparing/#include-a-readme-file @mithro: I will take out these two points into a...

@mithro: Does that #7 resolve this?

@mithro: Briefly, until we prepare full repos of caravel test cases, what the documentation checks do currently is the following: 1. check for a top level (in the main page)...

> @agorararmard - As we only have two checks, I think it is pretty simple to create some tests which should cover the failing and passing use cases? @mithro: The...

> I also don't think we need to be any more strict about documentation. Roger that.

@mithro: It was tested independently after disabling the rest of the checks (which is not the default behavior). Anyhow, what I did is that I tested on the OpenLANE repository...