Isaac W

Results 15 comments of Isaac W

Yeah, this issue has come up before - it doesn't handle non-ascii data well, which is totally a shortcoming. I just haven't really updated this package in forever - I...

Perhaps we could simply have sha1 require crypto when it's needed, and memoize? Will browserify still pull in require statements in a function body or no?

Ironically, it should work fine in the browser without browserify - it’s actually browserify that makes it not work :-(

No, but I mean base32 loads and you can use all the other methods, right?

Right, but typically one uses browserify to take a module that doesn’t work in the browser and make it work, while this already works in the browser and only brings...

I think you're right! I haven't worked on this in a while... hmm. A test case would be nice. It's also possible that it's wrong without resulting in wrong behavior,...

Generally speaking, this should be rewritten as a TransformStream. It's _OOOOLD_.

Can you explain?

``` $ node > var alphabet = '0123456789abcdefghjkmnpqrtuvwxyz' undefined > alphabet.length 32 ```

This isn't something I'd want to add by default - to me it looks cluttered, and a core principle of the theme is to be sparing with information so that...