Agis Anastasopoulos
Agis Anastasopoulos
We could get rid of our own and use https://github.com/stretchr/testify.
We now have a script for doing this. Ideally, we want the server to do this automatically. One should be able to configure how much usage each project should consume...
To do this, we have to: 1) extract any server-aware methods from Job into Server or something (to decouple Server from Job) 1) extract the job type to a package...
Any updates on this one? /cc @durran @estolfo
@jonhyman Hey, are the issues you mention in [your comment](https://github.com/mongoid/moped/pull/359#issuecomment-104672253) fixed in 2.0.7 which contains #380? Or do you still use a fork?
https://github.com/golang/go/issues/16930 is now closed. We should verify that rafka built with Go 1.13 no longer suffers from this issue, and close this. Also relevant: https://github.com/golang/go/issues/30333.
After testing with go tip (65ef999), the situation is pretty much the same as before. So I'm leaving this open as a known issue.
For now, what we want is a simple count of errors in the producers & consumers.
At the very least, the Sentry integration should only kick in if the gem is loaded (e.g. `defined?(Sentry)`). I believe this should solve your issue @danielwestendorf, right?
Hey @danielwestendorf, any chance you've seen my message above? Would something like that work for you? In any case, I can prepare a PR so you can test it.