rspecq icon indicating copy to clipboard operation
rspecq copied to clipboard

Remove sentry as a required dependency

Open danielwestendorf opened this issue 2 years ago • 2 comments

We use a different bug tracking tool than sentry. Adding rspecq to the gem file and running some tests results in failures. I have traced this back to conflicts between the two bug tracking tools.

Since it doesn't make sense for us to include sentry in our dependency graph, does it make sense for sentry to be an optional dependency?

danielwestendorf avatar Aug 24 '22 23:08 danielwestendorf

Sentry should be abstracted away to an interface that may or may not send results to some api. That is true. There are a number of ideas on how this can be done, for example as events (active support notifications, kafka) and/or plugins (like sentry, datadog etc).

fragoulis avatar Aug 25 '22 06:08 fragoulis

At the very least, the Sentry integration should only kick in if the gem is loaded (e.g. defined?(Sentry)). I believe this should solve your issue @danielwestendorf, right?

agis avatar Sep 07 '22 07:09 agis

Hey @danielwestendorf, any chance you've seen my message above? Would something like that work for you? In any case, I can prepare a PR so you can test it.

agis avatar Oct 25 '22 07:10 agis