Anton Gilgur

Results 766 comments of Anton Gilgur

> Also it's odd that the logs are complaining about `system:serviceaccount:argo:argo` permissions, even If I am not setting the service account to `argo` in the Workflow. Based on the [documentation](https://argo-workflows.readthedocs.io/en/stable/workflow-rbac/)...

As previously discussed [on Slack](https://cloud-native.slack.com/archives/C0510EUH90V/p1714988008178989), I couldn't think of any problems with it at the time, so I imagine it might've just never been implemented or requested. Giving it a...

> #### Modification 2 > Agent pod will only be created when taskset nodes exist, so do not delete it if it does not exist. @jswxstw can you split the...

> New PR: https://github.com/argoproj/argo-workflows/pull/13294 Thanks! Approved. Should merge once tests succeed. > I don't have permission to assign. Ah right. For future reference, I think you can "Request a Review"...

Follow-up to #13018 / https://github.com/argoproj/argo-workflows/pull/13018#discussion_r1594188099 > This commit will require changes to the Required steps in github which I cannot do myself. Neither can I. Only @terrytangyuan and @sarabala1979 can...

> `merge-multiple` doesn't work in v3. The docs are not versioned, so it's hard to discover how stuff should work. So that's part of why I'd updated, I remember now....

@ghepesdoru was looking for typings for this package and saw that you made this PR. Have you considered contributing these typings to [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped) to create a `@types/rollup-plugin-re` package?

So I gave this a go trying to implement one more provider (probably not the easiest one) and this is definitely going to require some refactoring. The `api.js` file will...

So loading chapters in the main view and highlighting mangas with new unread chapters should definitely be in 1.0.0. I find myself using other apps without this feature as otherwise...

For anyone interested, [this commit](https://github.com/agilgur5/github-label-manager/commit/7125bdfc0d10d12cefa42f8f5f376ce0923de30d) on my fork adds multi-page label support