Anton Gilgur
Anton Gilgur
I wasn't able to backport this into v3.5.x as it has a merge conflict b/c it depends on #12858, which itself has a merge conflict b/c it depends on #12847...
Correct, the `main` branch tracks _development_, which includes new features and breaking changes of any subsequent minor, and #12847 is a breaking change (as it may not work on older...
> We could use a json package from `kubernetes-sig` [project](https://github.com/kubernetes-sigs/json/blob/bc3834ca7abd3a90f03ef00a27ad80cb892f9c21/json.go#L61) , which allows `unmarshaling` with `case-sensitive` field tags. This seems to be directly available as `json.Unmarshal` in the `apimachinery` package:...
> Regarding, `argo lint` is on the `ParseObjects` from `common/parse.go`, which calls the `toWorkflowTypeJSON`. Mmm [this line](https://github.com/argoproj/argo-workflows/blob/b560ad383d3a7227964c4e4a30e7b69ce6bc9b03/workflow/common/parse.go#L28) only affects JSON structured inputs though, while most users and OP use YAML
Ah I see on [this line](https://github.com/argoproj/argo-workflows/blob/b560ad383d3a7227964c4e4a30e7b69ce6bc9b03/workflow/common/parse.go#L99). My only concern there is that we'd want to do strict + case-sensitive, which may require implementing in `pkg` unless the k8s package can...
> The warnings are concerning two external libraries, autolinker and argo-ui. Yea they're both warnings you can ignore. There's also SCSS warnings on deprecated syntax in the Foundation UI library....
https://github.com/argoproj/argo-ui/pull/509 unblocked https://github.com/argoproj/argo-ui/pull/552 which unblocked #12516 and now the popup warnings have been resolved plus several others (install warnings and console warnings have been reduced as well)!
Sounds like a subissue of #12592. Afaik, dependabot doesn't run on other branches, so this would be largely the same as what we discussed in #12592, automatically cherry-picking into currently...
> but it only does security PRs on the main one ofc classic dependabot limitations... 🙃 security PRs require dependabot security alerts, which afaik aren't even configurable? Let alone run...
Fixed by #12620 based on [the above comment](https://github.com/argoproj/argo-workflows/issues/11889#issuecomment-1928872665). Thanks all!