Anton Gilgur

Results 1000 comments of Anton Gilgur

> Why is this a fix? because it fixes existing warnings. those warnings also become errors in #12516 could potentially word it as a `build` commit, although it doesn't directly...

> could potentially word it as a `build` commit, although it doesn't directly touch the build, the changes are to the source code. I re-worded it as a `refactor` so...

> Started discussion on Slack https://cloud-native.slack.com/archives/C0510EUH90V/p1706279158785129 Splitting out a new repo is a future-facing question, that historically has taken months+ to occur (the SDKs being a current example of that)...

> > @juliev0 I am comfortable merging this, but I don't have write access yet I think? > > Got it! Okay, should be soon. Crenshaw said he'd get to...

> Fixes #10395 If these are to be part of the same PR, could you add a description about that to this PR? It's only mentioned on this one line....

Hmm, the groups change might be better as a separate PR since it's a fix while the secrets are a feature. When together, the fix is not cherry-pickable. If I'm...

> What performance issue? Try opening any API method in the Swagger UI and watch it lag, freeze, or straight up crash the browser window. It's a very prominent issue...

Gonna merge this in as it has already been approved and is a nice perf boost for the docs. I also already upgraded the UI to v5 in #12540, which...

> To Note, I believe this is the same issue as in #9934 which does have reproducible workflows attached That one doesn't use a `daemon` container, so would not apply...