Anton Gilgur

Results 1000 comments of Anton Gilgur

> @agilgur5 The dependency isn't really installed in Nix via a `npm install -g` equivalent, so `npm list -g` will fail (I tested this out) Thanks for checking! I thought...

> No worries, I don't quite know how it works but I believe it might be due to not assuming a global node installation. Ah that would make sense if...

WASM / WASI could be a huge boon for plugins as it allows for code from almost any language to be executed in a secure, sandboxed way. There is already...

How are you resubmitting? Could you provide the code for reproduction purposes if you're using the CLI or API? As in, are you resubmitting via the API directly, via the...

> But it turns out that when using CLI / API the problem is more serious, since even in a regular submit it is possible to pass any value to...

> ``` > # kubectl exec e526db50-4dd4-4daa-b4b7-5a80e40fefba-r9mpq-1081882305 --stdin --tty -c main -n argo sh > Error from server (Forbidden): pods "e526db50-4dd4-4daa-b4b7-5a80e40fefba-r9mpq-1081882305" is forbidden: cannot exec into or attach to a...

> When using the depth parameter, directories in the source repository will be lost This sounds like they used the [`depth` field](https://argo-workflows.readthedocs.io/en/latest/fields/#gitartifact), i.e. `git clone --depth` for a shallow clone...

> One potential solution could be adding the `DisableContentSha256` option [at this location](https://github.com/argoproj/pkg/blob/master/s3/s3.go#L215). Exposing this option in artifact config could make sense > Unfortunately, when uploading to Google Cloud, the...

Thanks for taking the time to investigate and fix this! Per the in-line comments, we may want to refactor some _existing_ logic that this PR highlights as potentially having broken...