Yichun Zhang

Results 937 comments of Yichun Zhang

Well, ngx_http_lua already supports the `init` parameter of `incr`, and we can utilize it here in this library. I don't want this library to depend on a new 3rd-party nginx...

@alonbg the standard lua_shared_dict implementation in ngx_http_lua_module already supports lists (or queues). Check it out to see if it fits your needs.

@Vittly Thank you for the patch! I'll look into this shortly :)

@JakSprats I guess it is untested too ;) Patches welcome! (For both docs and tests :)) Thanks!

@DrDinosaur I've run ngx_headers_more's test suite with nginx 1.6.0 and all tests are passing. Will you try ngx_headers_more without ngx_pagespeed (and other 3rd-party modules)? It is known that ngx_pagespeed can...

@DrDinosaur BTW, the recommended syntax for the `more_clear_headers` directive is like this: ``` nginx more_clear_headers Server X-Page-Speed X-Powered-By X-CF-Powered-By; ``` Consult the documentation for more details: https://github.com/openresty/headers-more-nginx-module#more_clear_headers

@DrDinosaur Then I think you should report the issue to ngx_pagespeed's maintainer instead.

@gholly Concatenating multiple SQL statements in a single query string should save several roundtrips between your nginx server and the mysqld server, and thus faster. You do not really need...

@gholly Before optimizing anything, you should determine the bottleneck first. If you cannot max out your nginx worker processes's CPU usage to 100% then your mysqld server is the bottleneck....

@manish786 You cannot directly cross the request boundary to manipulate a cosocket object that the current request does not create. The `bad request` error message clearly indicates this misuse. This...