Yichun Zhang
Yichun Zhang
@p0pr0ck5 Will you please rebase to the latest master? Sorry for the delay on my side. I'm about to look at it but found it has conflicts with the latest...
@p0pr0ck5 Cool, thanks! I'll have a look.
@honwel It is your responsibility to read or discard the request body when using `ngx_echo`. Basically you need to put the following line before `echo_subrequest_async`: ``` echo_read_request_body; ``` See https://github.com/agentzh/echo-nginx-module#echo_read_request_body...
I think it's a bit confusing to use the two words "timeout" and "exptime" in the same API since they are essentially the same thing in this context. I think...
@lloydzhou Patches welcome! :)
Using files to store the context seems to be too specific. Maybe it's sufficient to expose APIs to fetch and restore (opaque) ctx data? Like adding the get_context and set_context...
I think it's better to expose an option to let the user decide whether to use `add` or `safe_add`. Not every use case requires such strictness, for example, in the...
We also need test cases in the existing test suite for this new feature.
@hkmo We should return an error message string instead of a low level error code. See other Lua API functions in this Lua library for examples.
@hkmo Also, you need to pass the Travis CI testing associated with this PR. It's currently failing (see below on the web page).