Yichun Zhang

Results 937 comments of Yichun Zhang

@detailyang Thanks for the contribution! Please take care of the issues pointed out by my comments above. Thanks!

@sinogermany I can buy the idea of lazily returning the data rows but I don't buy the event hook API. Basically we can expose a fetch_row function to extract data...

@sinogermany BTW, we've been trying hard to avoid asynchronous callback APIs because we know how horrible the control flow can be when looking at native NodeJS code :)

@sinogermany Great! BTW, you can find documentation for the test scaffold here: https://metacpan.org/pod/Test::Nginx::Socket::Lua and here: https://metacpan.org/pod/Test::Nginx::Socket Please let me know if you have any further questions :)

Please note that using `-t 'text/html'` in `more_set_input_headers` or `more_clear_input_headers` means filtering by the `Content-Type` _request_ header, rather than the response header. If checking the `Content-Type` request header is indeed...

@saravsars The ngx_headers_more module does not support this (yet). I suggest you use [ngx_lua](http://wiki.nginx.org/HttpLuaModule) module's [rewrite_by_lua](http://wiki.nginx.org/HttpLuaModule#rewrite_by_lua) or [access_by_lua](http://wiki.nginx.org/HttpLuaModule#access_by_lua) directive to do this for now. For example, ``` rewrite_by_lua ' local...

@NagamineLee You should use `lua_shared_dict` instead of `limit_req_zone` in your config. They are very different things. Do not mix them and read the docs.

@NagamineLee Please provide a minimal and self-contained example that we can easily reproduce the problem on our side. We don't want to guess.

@NagamineLee Also detailed steps to reproduce the problem and your actual output in each step would be very useful.

@ctrochalakis Tagged a `v0.30rc1`. Not ready for a new formal release yet.