Yichun Zhang
Yichun Zhang
@Tieske Yeah, the current implementation assumes that the peers list is static and never change (except HUP reload, of course). That's an artificial limitation which should be removed if we...
Thank you for your patches! It'll be even more appreciated if you can 1. add corresponding test cases to the existing test suite, 2. remove unrelated minor changes from the...
Perfect! Thank you for your contribution! I'll look into your patches soon :)
Your test case "TEST 2: large query" in t/large.t is failing on my side. I'm getting the following error: ``` send() failed (32: Broken pipe) ``` Do you have any...
And I'm getting the same error while running your "TEST 3: large row" in t/large.t: ``` t/large.t .. 1/3 # Failed test 'TEST 3: large row - response_body - response...
Hello! 2013/3/27 AzureWang [email protected] > 我这边在mysqld设置max-allowed-packet=200m > 使用我打过补丁的代码三个测试都正常通过。 What happens if you use the default mysqld setup? I think the tests should pass with the default mysqld configuration. -agentzh
Hello! On Wed, Mar 27, 2013 at 7:21 PM, AzureWang [email protected] wrote: > 你确定打过补丁在跑的测试? Yes, of course. I was on your fork's master. Regards, -agentzh
Hello! 2013/3/27 AzureWang [email protected] > 你可以把你的mysqld信息告诉我一下,我按照你的mysqld环境在测试一下。 I'm using Fedora 17's mysqld (everything updated from the official yum), with the default configuration. -agentzh
Okay, I get it now :)
@detailyang Please use the [ngx-releng](https://github.com/openresty/nginx-devel-utils/blob/master/ngx-releng) tool to check the coding style and other issues in your changes. Also, please use the [reindex](https://github.com/agentzh/old-openresty/blob/master/bin/reindex) tool to re-format your `.t` files.