Yichun Zhang

Results 937 comments of Yichun Zhang

@aviramc When you kill a thread being waited by its parent, I think you should notify the sleeping parent somehow.

@aviramc Sorry for the long delay on my side! I've made some more comments. Will you please look into them? Thanks a lot!

@davecramer I've tried the following minimal example with the latest ngx_headers_more (v0.25) and nginx 1.5.11 and it works flawlessly: ``` nginx location = /t { return 414; more_set_headers -s 414...

@davecramer > I am using this in a reverse proxy and actually providing a request URI > that is too large. Is it possible that it isn't handled properly in...

@bAndie91 Not really. Better serve such "range" requests yourself directly in the content handler (like [content_by_lua](https://github.com/chaoslawful/lua-nginx-module#content_by_lua)).

@splitice I think we need separate version checks for each subsystem :)

@splitice Or maybe we should make the version to mean the API version number across different subsystems?

@splitice It seems to me that ensuring these different ngx_xxx_lua modules share the same API version number is very important.