lua-resty-core icon indicating copy to clipboard operation
lua-resty-core copied to clipboard

Version Number Check

Open splitice opened this issue 8 years ago • 6 comments

The version number check fails in the stream lua module.

splitice avatar Feb 04 '16 23:02 splitice

@splitice I think we need separate version checks for each subsystem :)

agentzh avatar Feb 04 '16 23:02 agentzh

@splitice Or maybe we should make the version to mean the API version number across different subsystems?

agentzh avatar Feb 04 '16 23:02 agentzh

@splitice It seems to me that ensuring these different ngx_xxx_lua modules share the same API version number is very important.

agentzh avatar Feb 04 '16 23:02 agentzh

@splitice Patches welcome :)

agentzh avatar Feb 04 '16 23:02 agentzh

I would keep the module version numbers the same between http and stream. Or atleast the Major/Minor.

Simplifies things a bit. And should help prevent compatibility issues between different versions of the modules (perhaps an issue in the future with future code re-use?). Added bonus, it doesn't require a patch.

splitice avatar Feb 04 '16 23:02 splitice

@splitice Agreed :)

agentzh avatar Feb 04 '16 23:02 agentzh