Adam Gent
Adam Gent
I also noticed that I forgot to use spaces instead of tabs. I used tabs because SpringSource used to use tabs (I'm not sure if they still do).
@chrylis and @sps this patch is to enhance partial support and to add rudimentary layout support. I have mostly switched to Handlebars.java which has its own way of doing layout...
Also this: https://github.com/avaje/avaje-config/blob/6915e81da2cad1927da0032eccc8740aafc7a0ac/avaje-config/src/main/java/io/avaje/config/InitialLoadContext.java#L102 Should throw either `UncheckedIOException` or ignored (as in the file no longer exists). EDIT that whole code block looks like duplication of stuff that Configuration.builder should do...
Not that it is super important but calling the ServiceLoader even just once is actually a significant cost. That is a better solution is actually to have `ResourceLoader`, `ConfigurationLog`, `ModificationEventRunner`...
@SentryMan Hey aren't you on vacation? Go back to enjoying that 😄 Also I owe it to you and @rbygrave to be tasked with things so let me know if...
> I don't know what you mean by that. Maybe you are referring to ClassLoader.getSystemResourceAsStream. Oh what I mean is `builder.load(File|Resource)` sort of implies that it will fail if it...
@rbygrave Sorry for the delay on the response. The only reason why I can see making `load() = loadRequire()` is because prior to the RC release it essentially was by...
So I'm good with `load` being optional. The only thing I think that would seal the deal for me is to make `load` doing some logging at say `TRACE` on...
What JDK version is avaje config compiled? If 17 @SentryMan parent the class that is to be registered as the **one and only** SPI a sealed class like I did...
@SentryMan sorry for the sporadic comments (its post work and on and off). But I forgot to add the `ServiceLoader` is like a memoized supplier. That is it is cached....