Results 127 comments of Adam Gausmann

I'm not quite sure about publishing yet. You can always add it as a git dependency: ```toml atmega-usbd = { git = "https://github.com/agausmann/atmega-usbd.git" } ```

Just want to put out a PSA - I haven't worked with atmega+USB in a while, and I don't think I can spend much time on it for the foreseeable...

I can't compile with this version: ``` $ cargo +nightly-2023-05-15 b --release --example arduino_keyboard ... LLVM ERROR: Expected a constant shift amount! ``` `nightly-2023-03-24` works fine however.

[Example crate using this API](https://github.com/agausmann/HWLife/tree/398506e781ead68a50e62610ec5dd277db284097/life-cell/firmware) The generated machine code looks okay, all the I/O memory and SRAM accesses look correct. (Note, it may be difficult to find a GCC toolchain...

I think I noticed a logic error in the open-drain implementation. `Pin::into_opendrain_high()` doesn't call `PinMode::out_clear()`: https://github.com/Rahix/avr-hal/blob/8e4ba8f2a097b28459e35528e9f3d89dcf2a6c39/avr-hal-generic/src/port.rs#L152-L171 ... and also, `Pin::set_low()` only calls `PinMode::make_output()`, and also doesn't call `PinMode::out_clear()`: https://github.com/Rahix/avr-hal/blob/8e4ba8f2a097b28459e35528e9f3d89dcf2a6c39/avr-hal-generic/src/port.rs#L338-L348 Because...

Oh, nice! They look pretty similar. The `.pullupen().bit(bool)` is a better way of doing that, I forgot about the `bit` method. The other differences I noticed: - In mine, the...

I think I would err on the side of generating less code, even if the `match` is usually optimized out. Having "yet another identifier" is not really that costly, especially...

I just noticed the avr-device 0.5 release, I will rebase this PR tonight.

Would it be possible to package the GUI separately? For example, as a `makemkv-qt` or `makemkv-gui` sub-package.

See b6efcf2ea7059719446c4b52284e71b9926d02a3 as an example of a separate `makemkv-qt` package. I'm not very experienced with subpackages so there might be some issues with this template. But anyway, the motivation for...