comeback icon indicating copy to clipboard operation
comeback copied to clipboard

[FEATURE] Add a terminal plugin

Open agamm opened this issue 5 years ago • 4 comments

Is your feature request related to a problem? Please describe. Currently, you can't open terminals. Which is quite essential.

Describe the solution you'd like a terminal plugin like so:

terminal:
  cwd: <somepath>
  cmd: <a command I can run>

agamm avatar Mar 02 '19 21:03 agamm

We should consider the security problems that may arise in this plugin. (Command Injection is only cool when you're on the red team)

yammesicka avatar Mar 02 '19 21:03 yammesicka

@yammesicka hmm it's something that is prevalent in many places right now, how do you want to stop it? Mainly what I think is that this is a file that wouldn't go into production, in addition, why would you run comeback in production? We can try to detect and ask the user if he specifies before running unwanted codes (https://github.com/Mckinsey666/bullet ?)

agamm avatar Mar 02 '19 21:03 agamm

I just think of a user who runs .comeback recipe and don't think about the possibility of command injection.

yammesicka avatar Mar 02 '19 21:03 yammesicka

I just think of a user who runs .comeback recipe and d

It can happen right now, what do you propose?

agamm avatar Mar 02 '19 22:03 agamm