comeback
comeback copied to clipboard
[CODE] Plugin as a class
Creating a Plugin class will help create:
- logical inheritance of plugins (like: Plugin->IdePlugin->PycharmPlugin)
- clear and enforceable interface for a plugin (like: run, check etc...)
- common code for all plugins (for example: Determining the OS and running the correct run function)
This is a great idea! I like your second and third points the most. PS, if you have time 🤞, you are welcome to work on it. Here, you are awesome in any case.
What do you think about keeping the run_plugin
and having the class, so people could choose if they want to use classes or not? or will it make a mess?
@yammesicka @yoavgolan
Maybe we can add some @shitty_decorator
that will wrap functions to make it compatible :)
@look_at_me_im_a_plugin_class
def run_plugin(params):
pass
Maybe we can add some
@shitty_decorator
that will wrap functions to make it compatible :)@look_at_me_im_a_plugin_class def run_plugin(params): pass
That's cool. That way we keep both ways working, right?