Results 44 comments of Aurora Gaffney

@rakshasa if you could provide a high-level description/overview of the changes, that would be helpful in reviewing this

The idea is to use Go's type switch/assertion for determining the cert type, since multiple types are returned using the `ledger.Certificate` interface. However, we have the information readily available to...

I created the upstream issue https://github.com/fxamacker/cbor/issues/508 for this

A different one ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x6361d6] goroutine 5 [running]: github.com/blinklabs-io/gouroboros.(*Connection).ErrorChan(...) /home/agaffney/dev/blinklabs-io/gouroboros/connection.go:124 github.com/blinklabs-io/gouroboros/protocol/handshake_test.TestServerHandshakeRefuseVersionMismatch.func1() /home/agaffney/dev/blinklabs-io/gouroboros/protocol/handshake/server_test.go:128 +0x16 created...

``` panic: runtime error: index out of range [0] with length 0 goroutine 24 [running]: github.com/cloudstruct/go-ouroboros-network/protocol.(*Protocol).recvLoop(0xc0000e4090) /home/agaffney/dev/cloudstruct/go-ouroboros-network/protocol/protocol.go:101 +0x545 created by github.com/cloudstruct/go-ouroboros-network/protocol.New /home/agaffney/dev/cloudstruct/go-ouroboros-network/protocol/protocol.go:46 +0x17b ```

We now have a mock Ouroboros conversation test framework that mostly covers this

It probably makes sense to use something like the Observer pattern to allow the consumer to subscribe to receiving various event alerts https://github.com/tmrts/go-patterns/blob/master/behavioral/observer.md https://refactoring.guru/design-patterns/observer It may also just make sense...

Those steps should probably happen before the post-install script runs

I'm not ignoring this, but I haven't used it myself in a few years, and I'm no longer using the device that I originally wrote it for.

We have support for a "query" flag in the handshake version data, but we don't do anything with it. From the Ouroboros network spec: ``` query, a boolean value: True...