Charles Swanberg
Charles Swanberg
I'm able to test this now. Is there a prerelease available?
I haven't completely vetted this yet, but this seems to work well so far in my testing: ``` #if __LP64__ #define SCRIBBLE_MARK 0x5555555555555555 #else #define SCRIBBLE_MARK 0x55555555 #endif ``` Maybe...
I have found another issue with testing. It might not be a blocker for most, but for our usecase using Codespaces it is. The default token loaded in a Codespace...
@Tatskaari @tiagovtristao could someone help me debug this? My last commit adds a fix that should allow the download with a less privileged token from GitHub. I also did it...
> is the `-L` flag/follow redirects option the only change needed? Technically. But if we could make the api.github.com url work I think it's an improvement for private repos because...
@tiagovtristao, I updated this PR to remove the comment. This makes the PR valid and works as is. It's really hurting my project's momentum without this, so I want to...
I did notice that as well and in my testing was forcing curl by setting the `Accept` header. I confirmed that a valid zip downloads, it just oddly seems to...
Tried this: ./pleasew plz build //test/remote/... Doesn't work. @afterthought ➜ /workspaces/please (remote-file-follow-redirects ✗) $ ./pleasew plz build //test/remote/... Can't determine version, will use latest. Downloading Please 16.19.0 to ./plz-out/please/16.19.0... Should...
@Tatskaari we can actually merge this as is!!!! I just tested and confirmed that if I supply my own strip_prefix to the github_rule it works. Keep in mind this is...
@Tatskaari @tiagovtristao bump. If you don't think we can merge this anytime soon, maybe you can help me get my own fork/build process setup. I can build it obviously, but...