Afshin Zade

Results 13 comments of Afshin Zade

> I would prefer the use of keywords instead of tags, but I assume that this function should be capable of dealing with private attributes as well. Should it? It...

> > > I assume that this function should be capable of dealing with private attributes as well. Should it? > > > It shouldn't I guess. I just preferred...

> The main logic seems to be implemented in the `FrameSet._find_per_frame_and_shared_tags()` method, which updates the `FrameSet._shared_tags` and `FrameSet._perframe_tags` attributes. Could we just create a utility function (in `highdicom.sr.utils`) instead with...