Afshin Zade
Afshin Zade
The complete list of missing modules: 1. module multi-frame-overlay missing from iod: nm-image 2. module multi-frame-overlay missing from iod: rt-dose 3. module multi-frame-overlay missing from iod: x-ray-angiographic-image 4. module multi-frame-overlay...
I checked the newly generated _iod and _module files. Some modules are missing: 1. module **real-time-audio-waveform-current-frame-functional-groups** missing from iod: **real-time-audio-waveform** 2. module **real-time-video-endoscopic-image-current-frame-functional-groups** missing from iod: **real-time-video-endoscopic-image** 3. module r**eal-time-video-photographic-image-current-frame-functional-groups**...
No, I don't need them. I just ran a test on all iods and modules to see if all modules are included.
> @afshinmessiah please fix typing errors locally before pushing to avoid test pipeline failures such as this one > https://travis-ci.com/github/MGHComputationalPathology/highdicom/jobs/430572557 Sorry, these days I'm doing so many tests/debug to convert...
@hackermd, I applied all modifications you wanted. Please take a look and let me know if anything is left.
Just finished the second round of code modification and tried to apply the required changes and corrections.
Just pushed updates for the recent comments. All recent comments were applied except making the FrameSet and FrameSetCollection classes private which was not possible due to their external usage.
Thank you @CPBridge for all your wonderful comments. I did my best to apply all changes required by the comments and not to leave out any. Except few comments to...
>This appears to be a particular point of disagreement/confusion holding this all back, so I want to try and sort this out. My position, and I think this mostly reflects...
@fedorov, after all, within `LegacyConvertedEnhancedXImage` class we need to use the FrameSet class logic to identify if the single-frame list is a mixed one or not. Whatever check we use...