Alekos Filini

Results 108 comments of Alekos Filini

I was going to suggest to just avoid spending unconfirmed utxos even if they come from ourselves, but if I understand this correctly even if we wait one confirmation it's...

Wait, I'm a bit lost on this: the PR says that this is actually not a problem because miniscript correctly checks for the timestamps as well, so I guess we...

That's a bit generic, what do you mean exactly? Which utxos should be spent (normal deposits or channel utxos) and where are those keys stored?

I haven't tried implementing it yet, but I think the main issue is gonna be the fact that basically all JS APIs are async. And it's not just the fact...

Interfacing with JS library is not that easy, so I would just use `gloo-storage` instead if you need to get something done quickly.

I'm not adding any review comments since I can see this is still at the beginning, I'm just gonna say (as you've probably already realized) that ideally we should try...

Yeah that's a good point, let's see how the code looks once we are done and then we'll decide.

I don't think it's easy to account for the extra weight ourselves, we basically have to do minisiscript's job of counting how many signatures can end up in a script...

I would first give it a shot with the core approach and see what happens. If it turns out to be too messy we can try with something else, but...

Agreed that we can deprecate it to show a warning that it should not be used, but I'm not sure I would remove it completely anytime soon. The way I...