Alekos Filini

Sorry, I thought it was gonna be easier to generate an html report from the coverage file, but it actually depends on many files in your current environment. I would...

Code looks good but there are a couple of tests timing out, were they working locally on your machine?

Yes, I would like to fix this for the next release because Core 23.0 has been out for a while and we are still not compatible with it. I can...

> block_headers_subscribe(), which now also returns the first header update, which is why the block_headers_pop() never returns a value (it was already returned on subscribe). Are you saying that even...

But the headers_subscribe call should not only send you the latest header immediately, it should also notify you when new blocks come in, without having to poll the server constantly....

So I think the way you've patched `wait_for_block` is actually the right way to do it, before we were assuming we would call `wait_for_block` before electrs had a chance to...

Note that the main goal for this task is not really to add more descriptors to the `Wallet` structure, but mainly to find a way to group multiple wallets into...

> In my mind wallets already have two descriptors with different semantics. I don't see why they couldn't have three or four or twenty four all in a Vec. Yes,...

I think I agree about passing a `&dyn Database`, I think most of the time the custom coin selection will just need access to the standard database interface, so that...

> The BIP links to this summary comments that says its in general a poor design, and cause privacy losses too in many use cases.. https://github.com/bitcoin/bips/wiki/Comments:BIP-0047 > > Any thoughts...