Alexis Hildebrandt
Alexis Hildebrandt
@badbob Is this something you'd be willing to continue pursuing?
Interesting suggestion, thanks, @Pranshugoyal 🙏
Kindly requesting review from @tbm.
Thank you for reporting @cpitclaudel. We are aware of the issue, and it has been bothering me quite a bit. I hope that we can address this issue alongside with...
Not sure what the issue is here. @n4s-linux can you please clarify? Is that ledger by default compiles with debug by default but shouldn't according to you?
Could be that changing to the `debug` build flavor by default was done unintentional. See https://github.com/ledger/ledger/blob/master/acprep#L234-L235, it seems the codelines date back to e0473e207b299858ef9550ed71be125a9db994ac when John "[r]ewrote acprep in Python...
After a quick investigation I think the performance improvements are mainly due to [acprep setting `NO_ASSERTS`](https://github.com/ledger/ledger/blob/master/acprep#L860) (which I believe should be [`DISABLE_ASSERTS`](https://github.com/ledger/ledger/blob/master/CMakeLists.txt#L33) as that is the option declared in `CMakeLists.txt`,...
To better understand your measurements, @n4s-linux, would you be willing to share how, i.e. with which commands, you measure performance and possible share your anonymised underlying dataset (e.g. `ledger print...
Thanks, @n4s-linux, and to get a better understanding how you measure performance, which commands do you run?
Note to self: Unless ledger is compiled with `DISABLE_ASSERTS` tracing, which may slow down ledger, is still available (see [`ledger.hh.in:64`](https://github.com/ledger/ledger/blob/master/src/ledger.hh.in#L64))