Alexis Hildebrandt
Alexis Hildebrandt
Ah I see, the query syntax vs. options was not clear to me. I'll rework this PR accordingly. I'm curious: What is the motivation to keep deprecated options around instead...
Thanks for the context, @lucc, on why the options are still around. I went ahead and reworked this PR so that it supports querying by `kind`. Being still rather unfamiliar...
Do you feel that the existing tests around the `kind` column (i.e. [`test_mixed_kinds` and `test_non_individual_kind `](https://github.com/lucc/khard/blob/develop/test/test_command_line_interface.py#L213-L232)) provide sufficient test-coverage for this PR to be merged, @lucc?
Thanks for the helpful review, @lucc; much appreciated. I went ahead and addressed your comments. How should `khard` behave if a non-standard value is given for `kind`, e.g. `person`? Should...
Regarding `KIND` on 3.0 contacts I decided to take the same approach as `khard` takes with `ANNIVERSARY` and prefix it with `X-` to make it a private attribute.
Friendly ping / nudge requesting re-review of the latest changes, @lucc 🙂
Thanks for your feedback @lucc, much appreciated 🙏 - [x] Glad to hear that you think it is ok to support them 🙂 - [x] I've added a brief comment...
I thought about this a bit more and with my current understanding of things I'd like to run the following by you, @lucc: * What if `VCardWrapper` had its own...
@reyk What are your thoughts on the [changes](https://gist.github.com/tvlooy/8f5c9253f9e283eaee9a77e9721daa52) that @tvlooy did as an exercise to add support for custom error pages? IMO it would make a useful addition to `httpd...
@LydiaUwU I'm running musikcube (version 0.98.0 #6a440c69) inside tmux ([3.3a](https://github.com/tmux/tmux/releases/tag/3.3a)) with alacritty ([0.10.1](https://github.com/alacritty/alacritty/releases/tag/v0.10.1)) and am unable to reproduce the issue (see screenshot below). Which terminal and version of musikcube are...