Alexis Hildebrandt

Closing as invalid as the issue is with a downstream distribution.

I'm also okay with dropping Python 2 in the coming release and not wait for another release cycle. I haven't been following the mailing list or IRC too closely; has...

Odd the changes succeeded building and testing for me locally using nixpkgs; I'll investigate what is going (wr)on(g) with the checks here…

My build succeeded locally despite the compiler error as my flake.nix still declared `usePython = false` 🤦

ℹ️ The failing test on Linux `342 - RegressTest_786A3DD0` has been reported in #2176 and #2178 is an attempt to find the underlying cause.

ℹ️ Failing test should be resolved once #2178 is merged.

Thanks for merging, @tbm 🙏 After all this time thinking I'd never see the day… Thank you, Ledger Python 2 support, for having served so well for so long 🥲

Yes, that is possible, @dirkarnez! Just remove the `SHARED` keyword from the add_library(libledger SHARED ${LEDGER_SOURCES}) instruction in [`src/CMakeLists.txt`](https://github.com/ledger/ledger/blob/master/src/CMakeLists.txt#L282) and build ledger as usual; `libledger.a` is then build instead of `libledger.so`...

@madroach Mind merging the current state of master, which has seen some improvements regarding the checks run on PRs, to this PRs branch too?

Friendly ping for @madroach