affederaffe
affederaffe
> I like the idea. If you enable the trimming warnings, what warnings are reported? In particular handling of incoming messages. > > Do note that protobuf.net is heavily reflection...
> I don't however like calling CanHandleMsg for every single interface, maybe registration and a dictionary lookup would work better. > > See [807fa51](https://github.com/SteamRE/SteamKit/commit/807fa510b9a9b8b8aa5b8d79d436acccce3d6fb7) for previous attempt at that. It's...
> This is a very different approach to the one I was looking at, and I do like it. > > Keep in mind that consumers should be able to...
> One slight worry I have is that services directly return the service, which is an extension of `UnifiedService` instead of being a wrapper like `UnifiedService` I think this would...
> @affederaffe did you see my comment in regards to the incoming messages/notifications? Yes, sorry, time is currently sparse. I'll implement a few ideas and see what works best.
> Just a thought I had, calling `CreateService` multiple times like in [d9f6b1b](https://github.com/SteamRE/SteamKit/commit/d9f6b1b1d38d51823ca77f8e51648cafb2ce264a) might be problematic, as it returns a disposable service, and the handler is being added by the...
> This piece of code is not working (callback function handler not being called despite event arriving): > > ```cs > CallbackManager.Subscribe(OnIncomingChatMessage); > > CallbackManager.Subscribe(OnIncomingMessage); > ``` > > Previously...
> > You need to create the service the notification is coming from first > > He does in ArchiHandler. `ChatRoomClient` and `FriendMessagesClient` are missing, which is why the message...