affederaffe

Results 38 comments of affederaffe

Fixed in https://github.com/AvaloniaUI/Avalonia/pull/15685

Realistically, we should probably detect if a map uses v3 events and don't use a custom platform then since they will be incompatible anyways, resulting in no effects at all....

Only the PropertyChanges type was made internal as it should be, it was a mistake to make it public at first. It is safe to make it internal as it...

Avalonia.FreeDesktop.nupkg.xml ```xml CP0001 T:Tmds.DBus.SourceGenerator.PropertyChanges`1 baseline/netstandard2.0/Avalonia.FreeDesktop.dll target/netstandard2.0/Avalonia.FreeDesktop.dll ```

> As of the public API, can we have source-generated classes to be private? How could they be private? The private modifier only makes sense for nested classes, but for...

That makes more sense. In this case, every source-generated class is already internal and thus inaccessible for users.

> Sorry, missed the PR, will test tomorrow. @kekekeks Any updates on this?

The Linux implementation may use DBus instead of pulling in that many native dependencies, see https://specifications.freedesktop.org/notification-spec/notification-spec-latest.html. If it's desired, I could open a PR for that

After a complete of day of debugging, I still have no idea how and why it breaks. The current hypothesis is that it is caused by trimming. In any case,...

Should be fixed with https://github.com/affederaffe/BeatSaberModManager/commit/4591356fade0d50d903a1d271ee29ee14073957e. If this fix proves to be stable, I'll create a new release.