Andrea Fercia

Results 255 comments of Andrea Fercia

I'm all for adding headings and using an unordered list. Headings clearly identify sections of content, both visually and semantically. Screenshot fo the headings hierarchy reported by teh headingsMap browser...

I can confirm there are a couple of errors in this script that prevent correct behavior in Firefox. To be honest seems to me that Firefox behavior is right, I...

> The CSS property is still required as the color panel can have controls inserted via slot fills from any number of sources. It would be nice to understand how...

@aaronrobertshaw I found some time to wrap my head around this issue. Thankd foru your detailed explanation, much appreciated. I played a bit with altering the Cover block code, just...

> The contrast warning there makes sense given it's after the color controls but before the overlay opacity. It's before the overlay opacity in the screenshot on the right, _where...

> Before jumping too deep into a PR, it might pay to get that design input upfront on this one. Possible solutions can then be discussed and settled upon here....

Thanks @aaronrobertshaw I will create a couple seeparate issues as the ContrastCheckeer appears to be buggy anyways. > I also couldn't replicate the multiple contrast checkers for the navigation block...

> It appears how the contrast checkers are added changed with #48893. @aaronrobertshaw thanks. Is this the relevant commit? https://github.com/WordPress/gutenberg/pull/48893/commits/d5297f2f7ec7045b560ddc9625187a7a01e8fd70 Does that mean that, since the contrast check is performed...

Thanks for the explanation @aaronrobertshaw The potential order you illustrated above: ``` ``` is exactly what I would like to see. From an usability and accessibility perspective, the contrast checked...

Posted some initial a11y feedback specific to the excerpt UI hre: https://github.com/WordPress/gutenberg/pull/60894#issuecomment-2082448458