Alberto Fernández-Capel
Alberto Fernández-Capel
@christian-bromann the current setup is rather flaky, any improvement to it will be welcomed.
Thanks for the pointer @johanneswilm, agreed it be nice to remove all `execCommand` altogether 👍
@ghiculescu I afraid I don’t maintain Trix anymore, so that ‘s up to the new maintainers.
@seanpdoyle AFAIK there's no WIP to implement `attachInternals`, but I think it's a brilliant idea and would happily accept a patch for it. Even if the feature is not fully...
@jcbpl no changes that I'm aware of. Hard to say what's going on, but if there has been a regression a failing test might help to pinpoint the issue.
@seanpdoyle thanks for kicking this off. `ElementInternals` is certainly the way of the future and it makes the whole setup look much simpler. It's also exciting that we will be...
> Do contributors need to register their own accounts and get their own secrets? Ugh, that's quite a hurdle for contributing. Ideally we would run the tests from the GitHub...
@seanpdoyle I've updated the CI script to only run tests on SauceLabs if it has access to an `SAUCE_ACCESS_KEY`. https://github.com/basecamp/trix/pull/1130
You can make the block view use a custom `className` attribute with something like 2cb3d42e44ef7f00ac18770e1a93c8b41730bd3c. I'm curious, though, why would you want to add a `centered` class to the heading...
@brendon nothing in the works, that I'm aware of, but happy to accept a PR implementing the feature.