basecamp
Fix CI
Test against the latest browser and OS versions. Android 9 is EOLed, test instead against Android 11 which is the oldest version still receiving updates.
Also test the latest Safari version.
As additional data points, both https://github.com/basecamp/trix/pull/1121 and https://github.com/basecamp/trix/pull/1122 timed out after 6 hours.
I've re-forked the repository and re-opened them as https://github.com/basecamp/trix/pull/1128 and https://github.com/basecamp/trix/pull/1127 to give them a chance to re-run.
Is this branch still viable as a solution?
After more investigation, I believe the issue is that forks do not inherit repository secrets:
With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.
This means that contributors submitting pull requests are executing their own suites in their own CI environments without access to SAUCE_USERNAME or SAUCE_ACCESS_KEY.
Do contributors need to register their own accounts and get their own secrets?
Do contributors need to register their own accounts and get their own secrets?
Ugh, that's quite a hurdle for contributing. Ideally we would run the tests from the GitHub actions instance if SAUCE_KEY is not present, and use Sauce Labs only on PRs. Running the tests locally is much more reliable than CI.
But there must be something else going on. The test randomly fail some times even when the SAUCE_KEY is present. Not sure exactly why, but the error messages look like connection problems.
@seanpdoyle I've updated the CI script to only run tests on SauceLabs if it has access to an SAUCE_ACCESS_KEY.
https://github.com/basecamp/trix/pull/1130